Re: [PATCH] Add hierarchical accounting to cpu accounting controller

From: Li Zefan
Date: Wed Nov 05 2008 - 01:20:45 EST


> +The CPU accounting controller is used to group tasks using cgroups and
> +account the CPU usage of these group of tasks.

this group or these groups?

...

> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9236,6 +9236,7 @@ struct cpuacct {
> struct cgroup_subsys_state css;
> /* cpuusage holds pointer to a u64-type object on every cpu */
> u64 *cpuusage;
> + struct cpuacct *parent;
> };
>

Maybe the comment needs to be updated?

/* track cpu usage of a group of tasks */
struct cpuacct {
...
};

->

/* track cpu usage of a group of tasks and its child groups */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/