Re: [RFC][PATCH 1/5] memcg : force_empty to do move account

[KAMEZAWA Hiroyuki]

On Mon, 3 Nov 2008 22:23:11 -0800
Paul Menage <menage@xxxxxxxxxx> wrote:

> On Mon, Nov 3, 2008 at 10:17 PM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> >> >
> >> >        mem = memcg;
> >> > -       ret = mem_cgroup_try_charge(mm, gfp_mask, &mem);
> >> > +       ret = __mem_cgroup_try_charge(mm, gfp_mask, &mem, true);
> >>
> >> Isn't this the same as the definition of mem_cgroup_try_charge()? So
> >> you could leave it as-is?
> >>
> > try_charge is called by other places....swapin.
> >
> 
> No, I mean here you can call mem_cgroup_try_charge(...) rather than
> __mem_cgroup_try_charge(..., true).
> 

you're right. will remove this change.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/