Re: [PATCH] ext3: wait on all pending commits in ext3_sync_fs

From: Andrew Morton
Date: Mon Nov 03 2008 - 16:13:51 EST


On Mon, 3 Nov 2008 12:58:54 -0800
Arthur Jones <ajones@xxxxxxxxxxxx> wrote:

> Hi Andrew, ...
>
> On Mon, Nov 03, 2008 at 12:37:50PM -0800, Andrew Morton wrote:
> > [...]
> > OK. But still, questions remain.
> >
> > - should we clear s_dirt if log_wait_commit() didn't work?
> >
> > - ext3_force_commit() clears s_dirt also
> >
> > - should ext3_sync_fs() be dropping the ext3_force_commit() return
> > value on the floor?
>
> - does ext4 have a similar issue (ext4_sync_fs looks the same)?
>

I'm sure it does. Someone(tm) should prepare the ext4 patch once we've
settled on the ext3 patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/