Re: [PATCH] Identify which executable object the userspace addressbelongs to. Store thread group leader id, and use it to lookup theaddress in the process's map. We could have looked up the addresson thread's map, but the thread might not exist by the time we arecalled. The process might not exist either, but if you are readingtrace_pipe, that is unlikely.

From: Ingo Molnar
Date: Mon Nov 03 2008 - 03:22:20 EST

Next message: Ingo Molnar: "Re: [PATCH] Identify which executable object the userspace addressbelongs to. Store thread group leader id, and use it to lookup theaddress in the process's map. We could have looked up the addresson thread's map, but the thread might not exist by the time we arecalled. The process might not exist either, but if you are readingtrace_pipe, that is unlikely."
Previous message: Li Zefan: "[PATCH] update 'isolcpus' kernel option"
In reply to: Török Edwin: "Re: [PATCH] Identify which executable object the userspace addressbelongs to. Store thread group leader id, and use it to lookup the addressin the process's map. We could have looked up the address on thread's map,but the thread might not exist by the time we are called. The process mightnot exist either, but if you are reading trace_pipe, that is unlikely."
Next in thread: Ingo Molnar: "Re: [PATCH] Identify which executable object the userspace addressbelongs to. Store thread group leader id, and use it to lookup theaddress in the process's map. We could have looked up the addresson thread's map, but the thread might not exist by the time we arecalled. The process might not exist either, but if you are readingtrace_pipe, that is unlikely."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

* Török Edwin <edwintorok@xxxxxxxxx> wrote:

> On 2008-11-03 09:47, Ingo Molnar wrote:
> > * Török Edwin <edwintorok@xxxxxxxxx> wrote:
> >
> >
> >> + struct task_struct *task;
> >> + /* we do the lookup on the thread group leader,
> >> + * since individual threads might have already quit! */
> >>
> >
> > please use the customary comment style:
> >
> > /*
> > * Comment .....
> > * ...... goes here:
> > */
> >
> >
>
> . Can checkpatch.pl warn me of situations like this?

Cc:-ed Andy - it would be a useful feature indeed. (since there's no
hard CodingStyle rule for it, it could be a default-off helper)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/