Re: [dm-devel] [PATCH] Add gfp_mask to bio_integrity_clone()

From: Jens Axboe
Date: Fri Oct 31 2008 - 10:18:26 EST


On Fri, Oct 31 2008, Martin K. Petersen wrote:
> >>>>> "Jun'ichi" == Jun'ichi Nomura <j-nomura@xxxxxxxxxxxxx> writes:
>
> Jun'ichi> What do you think about adding gfp_mask parameter to
> Jun'ichi> bio_integrity_clone() like the attached patch?
>
> Jun'ichi> It also seems natural to inherit gfp_mask from bio_clone
> Jun'ichi> when bio_integrity_clone is called from it. Since
> Jun'ichi> bio_clone() is the only caller of bio_integrity_clone() in
> Jun'ichi> 2.6.28-rc2 and all in-tree callers of bio_clone() are using
> Jun'ichi> GFP_NOIO, the patch does nothing other than changing the
> Jun'ichi> interface.
>
> Looks good to me. I'll update the non-multipath DM bits accordingly.
>
> Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

Shall I just include this in the 2.6.29 branch?

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/