Re: [PATCH] x86: fix missing cpu_index initialisation

From: Ingo Molnar
Date: Fri Oct 31 2008 - 04:44:50 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
> > > Depends on [VOYAGER] x86: add ability to test for boot CPU
> >
> > applied both to tip/x86/urgent:
> >
> > 6b5496e: x86/voyager: fix missing cpu_index initialisation
> > 3b25aec: x86/voyager: fix compile breakage caused by dc1e35c6e95e8923cf1d35104
>
> this broke the x86 build:
>
> arch/x86/kernel/cpu/common.c: In function 'early_identify_cpu':
> arch/x86/kernel/cpu/common.c:553: error: 'struct cpuinfo_x86' has no member named 'cpu_index'
>
> fixed via the patch below.

i just found a third build failure as well, caused by the voyager
fixes:

arch/x86/kernel/cpu/common.c: In function 'cpu_init':
arch/x86/kernel/cpu/common.c:1141: error: 'boot_cpu_id' undeclared (first use in this function)
arch/x86/kernel/cpu/common.c:1141: error: (Each undeclared identifier is reported only once
arch/x86/kernel/cpu/common.c:1141: error: for each function it appears in.)

(see the fix below)

this raises the urgency the conversion of x86/Voyager to normal x86
platform APIs.

Ingo

---------------->