Re: [PATCH] fix smp generic helper voyager breakage

[Ingo Molnar]

* James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, 2008-10-30 at 22:54 +0100, Ingo Molnar wrote:
> > * James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > > +++ b/arch/x86/Kconfig
> > > @@ -167,9 +167,11 @@ config GENERIC_PENDING_IRQ
> > >  config X86_SMP
> > >  	bool
> > >  	depends on SMP && ((X86_32 && !X86_VOYAGER) || X86_64)
> > > -	select USE_GENERIC_SMP_HELPERS
> > >  	default y
> > >  
> > > +config USE_GENERIC_SMP_HELPERS
> > > +	def_bool y
> > > +
> > 
> > uhm, that's a bogus change - USE_GENERIC_SMP_HELPERS must not be set 
> > on UP. This will break all UP compilations, on all x86 UP boxes:
> 
> Heh, that would be one thing I don't build in my test rig.

lets put it this way: that change, when put in my test rig, already 
broke more x86 boxes than there are working Voyager test-boxes in 
existence ;-) [it broke the build on three of them]

> > kernel/softirq.c: In function '__try_remote_softirq':
> > kernel/softirq.c:522: error: implicit declaration of function '__smp_call_function_single'
> > 
> > so i've removed your patch for now.
> 
> OK, I'll update it ... I assume it should depend on CONFIG_SMP then?

correct.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/