Re: hid: struct device - replace bus_id with dev_name(), dev_set_name()

[Jiri Slaby]

Kay Sievers napsal(a):
> switch over to the new api, which will remove the 20 bytes array
> and does no longer have a size limitation.

Cool!

> From: Kay Sievers <kay.sievers@xxxxxxxx>
> Subject: hid: struct device - replace bus_id with dev_name(), dev_set_name()
> 
> CC: Jiri Kosina <jkosina@xxxxxxx>
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> Signed-Off-By: Kay Sievers <kay.sievers@xxxxxxxx>
> ---
> 
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 721a36d..73ccc37 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1573,9 +1573,8 @@ int hid_add_device(struct hid_device *hdev)
>  	if (hid_ignore(hdev))
>  		return -ENODEV;
>  
> -	/* XXX hack, any other cleaner solution < 20 bus_id bytes? */
> -	sprintf(hdev->dev.bus_id, "%04X:%04X:%04X.%04X", hdev->bus,
> -			hdev->vendor, hdev->product, atomic_inc_return(&id));
> +	dev_set_name(&hdev->dev, "%04X:%04X:%04X.%04X", hdev->bus,
> +		     hdev->vendor, hdev->product, atomic_inc_return(&id));

Could you left the comment above to remind us about removing this ugly hack
later when the new non-limited api will be used?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/