Re: [PATCH] x86: simplify X86_MPPARSE config option

[Ingo Molnar]

* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:

> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> ---
>  arch/x86/Kconfig |   12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> --- linux-2.6.28-rc2/arch/x86/Kconfig	2008-10-30 11:03:18.000000000 +0100
> +++ 2.6.28-rc2-x86-kconfig-cleanup/arch/x86/Kconfig	2008-10-21 13:57:07.000000000 +0200
> @@ -235,21 +235,13 @@ config X86_FIND_SMP_CONFIG
>  	def_bool y
>  	depends on X86_MPPARSE || X86_VOYAGER
>  
> -if ACPI
>  config X86_MPPARSE
> -	def_bool y
> -	bool "Enable MPS table"
> +	bool "Enable MPS table" if ACPI
> +	default y
>  	depends on X86_LOCAL_APIC
>  	help
>  	  For old smp systems that do not have proper acpi support. Newer systems
>  	  (esp with 64bit cpus) with acpi support, MADT and DSDT will override it
> -endif
> -
> -if !ACPI
> -config X86_MPPARSE
> -	def_bool y
> -	depends on X86_LOCAL_APIC
> -endif

hm, that's not an equivalent change. But i guess we can do this, it 
sure looks like a cleaner construct.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/