Re: mmc: struct device - replace bus_id with dev_name(),dev_set_name()

From: Pierre Ossman
Date: Thu Oct 30 2008 - 05:10:20 EST


On Wed, 29 Oct 2008 18:48:04 -0700
Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

>
> A lot of these helpers don't seem to add that much, would you care for
> a patch removing them Pierre?
>
> Specifically sdio_func_id, sdio_get/set_drvdata don't have that many
> users.
>
> mmc_hostname has a lot of users, but if you're agreeable, I could
> take a crack at that too.
>

As Marcel said, they provide a nice abstraction (even if it is indeed
a bit silly to have wrappers around wrappers around ..). It also tends
to make the code a bit more readable.

Rgds
--
-- Pierre Ossman

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.

Attachment: signature.asc
Description: PGP signature