Re: x86_64: remove debug code from arch_add_memory()

From: Ingo Molnar
Date: Wed Oct 29 2008 - 04:31:26 EST



* Gary Hade <garyhade@xxxxxxxxxx> wrote:

>
> Gets rid of dmesg spam created during physical memory hot-add which
> will very likely confuse users. The change removes what appears to
> be debugging code which I assume was unintentionally included in:
> x86: arch/x86/mm/init_64.c printk fixes
> commit 10f22dde556d1ed41d55355d1fb8ad495f9810c8
>
> Signed-off-by: Gary Hade <garyhade@xxxxxxxxxx>
>
> ---
> arch/x86/mm/init_64.c | 1 -
> 1 file changed, 1 deletion(-)

applied to tip/x86/urgent, thanks Gary!

Note, i changed it slightly: instead of removing it completely i
changed it to WARN_ON_ONCE(ret), to show us when __add_pages() fails.
(which is what the original intention was there) This does not trigger
in your tests, right?

Ingo

--------------->