Re: [PATCH 2/2] w35und: plug memory leak in wbsoft_tx()

From: Pavel Machek
Date: Tue Oct 28 2008 - 15:30:41 EST


On Tue 2008-10-28 00:14:38, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
>
> There's no reason to duplicate the skb in wbsoft_tx() and leak GFP_ATOMIC
> memory as the contents are copied to ->TxBuffer in MdxTx() anyway before
> MLMESendFrame() returns.

Acked-by: Pavel Machek <pavel@xxxxxxx>

...but I guess I should test the this after it hits the mainline...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/