Re: [patch 3/7] mm: make page writeback obey cpuset constraints

[David Rientjes]

On Tue, 28 Oct 2008, Peter Zijlstra wrote:

> > +	is_subset = cpuset_populate_dirty_limits(dl, &dirtyable_memory,
> > +						 &nr_mapped, nodes);
> > +	if (!is_subset) {
> > +		dl->nr_dirty = global_page_state(NR_FILE_DIRTY);
> > +		dl->nr_unstable = global_page_state(NR_UNSTABLE_NFS);
> > +		dl->nr_writeback = global_page_state(NR_WRITEBACK);
> > +		dirtyable_memory = determine_dirtyable_memory();
> > +		nr_mapped = global_page_state(NR_FILE_MAPPED) +
> > +			global_page_state(NR_ANON_PAGES);
> > +	} else
> > +		dirtyable_memory -= highmem_dirtyable_memory(nodes,
> > +							dirtyable_memory);
> 
> Why not fold that all into cpuset_populate_dirty_limits() ?
> 

cpuset_populate_dirty_limits() is a no-op on !CONFIG_CPUSETS kernels.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/