Re: [PATCH, RFC] jbd2: Call the commit callback before thetransaction could get dropped

From: Eric Paris
Date: Tue Oct 28 2008 - 10:30:02 EST


On Mon, 2008-10-27 at 21:41 -0500, Eric Sandeen wrote:
> Theodore Tso wrote:
> > This is what I plan to send to Linus to fix the problem.
> >
> > commit 6fecbc3c7d27800e90a5f5fbca2fb2847e2c2854
> > Author: Theodore Ts'o <tytso@xxxxxxx>
> > Date: Mon Oct 27 22:11:39 2008 -0400
> >
> > jbd2: Call the commit callback before the transaction could get dropped
> >
> > The transaction can potentially get dropped if there are no buffers
> > that need to be written. Make sure we call the commit callback before
> > potentially deciding to drop the transaction. Also avoid
> > dereferencing the commit_transaction pointer in the marker for the
> > same reason.
> >
> > This patch fixes the bug reported by Eric Paris at:
> > http://bugzilla.kernel.org/show_bug.cgi?id=11838
> >
> > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
>
> Acked-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Tested-by: Eric Paris <eparis@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/