Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it's notneeded

[Haavard Skinnemoen]

David Brownell <david-b@xxxxxxxxxxx> wrote:
> From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> 
> The atmel_serial driver is mismanaging its clock by leaving it on
> at all times ... the whole point of clock management is to leave
> it off unless it's actively needed, which conserves power!!
> 
> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>

Hmm...the only remaining clk_enable() is in atmel_serial_pm(). Is that
really enough?

It looks like the serial core calls ->pm() to power the port up before
doing anything that might touch the registers, but I can't see that the
console layer does the same thing...

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/