Re: SLUB defrag pull request?

From: Pekka Enberg
Date: Tue Oct 28 2008 - 07:06:37 EST


On Thu, 2008-10-23 at 19:14 +0200, Eric Dumazet wrote:
> [PATCH] slub: slab_alloc() can use prefetchw()
>
> Most kmalloced() areas are initialized/written right after allocation.
>
> prefetchw() gives a hint to cpu saying this cache line is going to be
> *modified*, even if first access is a read.
>
> Some architectures can save some bus transactions, acquiring
> the cache line in an exclusive way instead of shared one.
>
> Same optimization was done in 2005 on SLAB in commit
> 34342e863c3143640c031760140d640a06c6a5f8
> ([PATCH] mm/slab.c: prefetchw the start of new allocated objects)
>
> Signed-off-by: Eric Dumazet <dada1@xxxxxxxxxxxxx>

Christoph, I was sort of expecting a NAK/ACK from you before merging
this. I would be nice to have numbers on this but then again I don't see
how this can hurt either.

Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/