Re: [RFC PATCHv3] printk: add %pM format specifier for MACaddresses

From: Johannes Berg
Date: Tue Oct 28 2008 - 04:06:49 EST


On Mon, 2008-10-27 at 17:22 -0700, Joe Perches wrote:
> On Mon, 2008-10-27 at 17:05 -0700, Harvey Harrison wrote:
> > On Mon, 2008-10-27 at 16:55 -0700, David Miller wrote:
> > > I'm ok with the '#' modifier but remind me again what's wrong with
> > > using plain %p4 and %p6?
> > Nothing at all, just wanted to know what color bikeshed you wanted.
> > I'll go with %p4 %p6.
>
> Just an FYI for v6 addresses:
>
> There are a few uses of ipv6 address as "%08X%08X%08X%08X"
> Pavel Emelyanov tried to isolate them with a suggested patch:
>
> http://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg51655.html
>
> These addresses are not shown in network order, but are
> printed backwards in host order. Oops. Apparently it's
> too late to fix them.

So that code we don't touch here at all.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part