Re: [PATCH] linux/timex.h: cleanup for userspace

[Andrew Morton]

On Sun, 26 Oct 2008 06:37:31 -0400 Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> Move all the kernel-specific defines and includes into the __KERNEL__
> section so that they don't get leaked into userspace.
> 

checkpatch correctly instructs us to use linux/param.h, not asm/param.h.

This:

--- a/include/linux/timex.h~linux-timexh-cleanup-for-userspace-checkpatch-fixes
+++ a/include/linux/timex.h
@@ -165,8 +165,8 @@ struct timex {
 #ifdef __KERNEL__
 #include <linux/compiler.h>
 #include <linux/types.h>
+#include <linux/param.h>
 
-#include <asm/param.h>
 #include <asm/timex.h>
 
 /*
_

seems Obviously Safe to me.  Do you agree?

(please use checkpatch - sometimes it's useful!)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/