Re: [PATCH 3/5] w35und: remove dead code from wbusb_f.h

From: Pekka J Enberg
Date: Mon Oct 27 2008 - 16:44:31 EST


Hi Greg,

On Wed, Oct 22, 2008 at 07:06:41PM +0300, Pekka J Enberg wrote:
> > From: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> >
> > Remove dead code from wbusb_f.h and move the WbWLanInitialize() definition to
> > wblinux_f.h where it arguably belongs to. As the wbusb_f.h is now empty, we can
> > remove it completely.
> >
> > Cc: Pavel Machek <pavel@xxxxxxx>
> > Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

On Mon, 27 Oct 2008, Greg KH wrote:
> This patch gives me a bunch of build errors as I don't think you are in
> sync with the other changes in these files.
>
> Care to respin it against 2.6.28-rc2?

That's strange. I rebased against 2.6.28-rc2 but didn't get any conficts
and everything seems to build just fine. What kind of errors are you
seeing?

I've included the rediffed patch here in case it helps. Not sure why it
would...

Pekka