Re: [PATCH] x86: unify appropriate bits from dumpstack_32 anddumpstack_64

[Alexander van Heukelum]

On Thu, 23 Oct 2008 10:40:06 -0400, "Neil Horman"
<nhorman@xxxxxxxxxxxxx> said:
> Hey all-
> 	As promised, now that dumpstack_32 and dumpstack_64 have so many bits in
> common, we should merge the in-sync bits into a common file, to prevent them
> from diverging again.  This patch removes bits which are common between
> dumpstack_32.c and dumpstack_64.c and places them in a common dumpstack.c
> which is built for both 32 and 64 bit arches.  
> 
> Regards
> Neil
> 
> Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

A bit late, maybe, but if it matters:

Acked-by: Alexander van Heukelum <heukelum@xxxxxxxxxxx>

Thanks Neil!

> 
>  Makefile       |    2 
>  dumpstack.c    |  319 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  dumpstack.h    |   39 ++++++
>  dumpstack_32.c |  294 ----------------------------------------------------
>  dumpstack_64.c |  285 --------------------------------------------------
>  5 files changed, 363 insertions(+), 576 deletions(-)
> 
> [...]
> 
> /***************************************************
>  *Neil Horman
>  *nhorman@xxxxxxxxxxxxx
>  *gpg keyid: 1024D / 0x92A74FA1
>  *http://pgp.mit.edu
>  ***************************************************/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
-- 
  Alexander van Heukelum
  heukelum@xxxxxxxxxxx

-- 
http://www.fastmail.fm - Choose from over 50 domains or use your own

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/