Re: [PATCH 1/1] SGI X86 UV: Provide a System Activity Indicator driver

From: Mike Travis
Date: Mon Oct 27 2008 - 10:37:24 EST


Ingo Molnar wrote:
...
>
> Please send the cpu_idle() cleanup patch separately.
>
> Another minor thing i noticed:
>
> @@ -130,7 +140,9 @@ struct uv_hub_info_s {
> unsigned char blade_processor_id;
> unsigned char m_val;
> unsigned char n_val;
> + struct uv_scir_s scir;
>
> please align the new field vertically, like they were aligned before -
> by adding another tab to the whole lineup. (This will also make it
> appear nicer when viewed together with followup definitions below this
> section)

Ok, will do, thanks!

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/