Re: [PATCH 2/2 v3] SGI RTC: add RTC system interrupt

[Ingo Molnar]

* Dimitri Sivanich <sivanich@xxxxxxx> wrote:

> +void uv_rtc_timer_interrupt(struct pt_regs *regs)
> +{
> +	struct pt_regs *old_regs = set_irq_regs(regs);
> +
> +	ack_APIC_irq();
> +
> +	exit_idle();
> +
> +	irq_enter();
> +
> +	if (uv_rtc_interrupt_extension)
> +		uv_rtc_interrupt_extension();
> +
> +	irq_exit();
> +
> +	set_irq_regs(old_regs);
> +}

hm, the exit_idle() looks weird - why is it done? If we get an IRQ 
then the CPU will exit idle state anyway.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/