Re: [PATCH 1/1] r8169: revert "read MAC address from EEPROM on init"

From: Jeff Garzik
Date: Sun Oct 26 2008 - 12:27:36 EST


Francois Romieu wrote:
This reverts commit 7bf6bf4803df1adc927f585168d2135fb019c698.

The code has both a short existence and an increasing track
of failures despite some work to amend it for -rc1. It is not
just a matter of reading the eeprom: sometimes the eeprom is
read correctly, then the mac address is not written correctly
back into the mac registers.

Some chipsets seem to work reliably but it is not clear at
this point if the code can simply be made to work on a
per-chipset basis and post -rc1 is not the place where I want
to experiment these things.

Signed-off-by: Francois Romieu <romieu@xxxxxxxxxxxxx>

Acked-by: Jeff Garzik <jgarzik@xxxxxxxxxx>

I'll send upstream if Linus doesn't pick it up shortly...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/