Re: [2.6.28-rc1 regression] wmifinfo dockapp takes 100% of cpu (bisected)

[Ray Lee]

On Sat, Oct 25, 2008 at 12:12 PM, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
> On Sat, 25 Oct 2008 20:03:27 +0200
> Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote:
>> > >           if (copy_from_user(&tv, tvp, sizeof(tv)))
>> > >                   return -EFAULT;
>> > >
>> > > +         while (tv.tv_usec > USEC_PER_SEC && i < 1000) {
>>                                   ^
>> should be >=
>
> yeah thanks for catching that. Note to self: don't code before coffee
>
> I'm not very happy with a while loop; but at least it solves the problem
>
> I'll try to make it nicer than this ...

Regardless, you may wish to make a set_normalized_timeval and place it
in kernel/time.c right after the current set_nromalized_timespec.
Comparing the two, you'll also want to handle the case where tv_usec
is negative.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/