Re: [PATCH] trace: add the MMIO-tracer to the tracer menu

[Pekka Paalanen]

On Fri, 24 Oct 2008 07:56:05 -0400 (EDT)
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> 
> On Fri, 24 Oct 2008, Ingo Molnar wrote:
> > >  #
> > >  # IO delay types:
> > > Index: linux-2.6/kernel/trace/Kconfig
> > > ===================================================================
> > > --- linux-2.6.orig/kernel/trace/Kconfig
> > > +++ linux-2.6/kernel/trace/Kconfig
> > > @@ -194,4 +194,32 @@ config FTRACE_STARTUP_TEST
> > >  	  functioning properly. It will do tests on all the configured
> > >  	  tracers of ftrace.
> > >  
> > > +config MMIOTRACE_HOOKS
> > > +	bool
> > > +
> > > +config MMIOTRACE
> > > +	bool "Memory mapped IO tracing"
> > > +	depends on HAVE_MMIOTRACE_SUPPORT && DEBUG_KERNEL && PCI
> > > +	select TRACING
> > > +	select MMIOTRACE_HOOKS
> > 
> > change makes sense, but isnt MMIOTRACE_HOOKS basically overlapping 
> > HAVE_MMIOTRACE_SUPPORT? So i think we could get rid of MMIOTRACE_HOOKS 
> > altogether and just use HAVE_MMIOTRACE_SUPPORT.
> 
> And doing this will remove the need about my question on depends on X86.

Yes, we can remove MMIOTRACE_HOOKS and replace it with just MMIOTRACE.
MMIOTRACE_HOOKS is a remnant from the time when I thought that
something else could also use the kmmio facilities.

Here's a compile-tested patch against current Ingo's tip/master.