Re: [PATCH] Check fops_get() return value

[Mauro Carvalho Chehab]

On Thu, 16 Oct 2008 15:28:00 +0200
Takashi Iwai <tiwai@xxxxxxx> wrote:

> >  
> >  	old_fops = filp->f_op;
> >  	filp->f_op = fops_get(&dev->driver->fops);
> > +	if (filp->f_op == NULL) {
> 
> I think the more standard style is
> 
>  if (!file->fop) {

Yes. This seems a good cleanup to the patch.

> 
> Except for that minor issue, it looks good to me.
> In any case,
> 
> Acked-by: Takashi Iwai <tiwai@xxxxxxx>

You have my ack also.

Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/