Re: [PATCH 1/1] SGI X86 UV: Provide a System Activity Indicator driver

From: Mike Travis
Date: Fri Oct 24 2008 - 08:13:30 EST


Pavel Machek wrote:
> On Fri 2008-10-24 04:19:04, Mike Travis wrote:
>> [Ingo - could you let me know what's holding up this driver?
>> Thanks!, Mike]
>
> I thought that...
>
> > +static __init void uv_scir_register_cpu_notifier(void)
>> +{
>> + hotcpu_notifier(uv_scir_cpu_notify, 0);
>> + idle_notifier_register(&uv_idle_notifier);
>> +}
>
> ...Ingo said that idle_notifier_register is deprecated and going away?
>
> Pavel

Is there any other way to get an indication then? This is also in ia64 code
though not with the formality of a callback -- it's a static function pointer:

arch/ia64/kernel/process.c:
void (*ia64_mark_idle)(int);

arch/ia64/sn/kernel/setup.c:
ia64_mark_idle = &snidle;

arch/ia64/sn/kernel/idle.c
void snidle(int state)
{
if (state) {
if (pda->idle_flag == 0) {
/*
* Turn the activity LED off.
*/
set_led_bits(0, LED_CPU_ACTIVITY);
}

pda->idle_flag = 1;
} else {
/*
* Turn the activity LED on.
*/
set_led_bits(LED_CPU_ACTIVITY, LED_CPU_ACTIVITY);

pda->idle_flag = 0;
}
}

As I mentioned, I would be happy to use an alternative but I haven't yet found one.
Should I put the above into x86_64?

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/