Re: [PATCH] Skip tsc synchronization checks if CONSTANT_TSC bit is set.

From: Andi Kleen
Date: Fri Oct 24 2008 - 03:15:57 EST


> That is at least to some degree nonsense, simply because we are all well
> down that particular "slippery slope": we have hardware blacklists and

The big difference is that hardware cannot be easily fixed, hypervisors
are just software and can as simply as Linux. Also there are at least
standardized simple ways to detect hardware and platforms using standard
enumeration interfaces like PCI or DMI, while each Hypervisor detection
seems to need huge amounts of custom (and likely fragile) complicated code.
iirc there was a vmware detection patch around and it was disgusting iirc.

Also I think this concept of "not PV, but then again a little"
concept that is mandated here is not a useful one.

Either do a proper PV interface and then just write a custom
clock driver and paravirt ops interface to make everything really fast,
or just use the direct hardware interface and fix the hypervisor
to do it properly.

Especially VMware has this already (although 32bit only).

Ok the tsc_sync issue is borderline, but that one seems
to be more a case of tweaking the existing algorithms
to be a little more tolerant.

-Andi
--
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/