Re: [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask

From: Rusty Russell
Date: Thu Oct 23 2008 - 18:53:20 EST

On Thursday 23 October 2008 23:03:22 Ingo Molnar wrote:
> I also added "Impact:" lines to every commit - a one-line summary of the
> expected outcome of the change. (Please double-check those impact lines
> - if you see anything odd it means that i missed some detail in the
> commit - that will need to be fixed if it happens.)

Note that "removed" and "deprecated" are using the terms loosely. No old API
was removed, and I didn't actually mark anything __deprecated (I just
documented it in the header).

Here are my revisions:

cpumask: cpu_all_mask and cpu_none_mask

-Impact: introduce new constants, convert old usage to them
+Impact: introduce new constants, convert core files.

cpumask: deprecate any_online_cpu() in favour of cpumask_any/cpumask_any_and

-Impact: cleanup
+Impact: new API, deprecate old

cpumask: cpumask_first/cpumask_next

-Impact: remove old API, convert all users to new API
+Impact: new API, deprecate old
(We convert one place only)

cpumask: for_each_cpu(): for_each_cpu_mask which takes a pointer

-Impact: remove old API, convert all users to new API
+Impact: remove old API, convert core trivial users

cpumask: cpumask_of(): cpumask_of_cpu() which returns a pointer

-Impact: cleanup
+Impact: new API, deprecate old API.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at