Re: [PATCH] tracing: fix a build error on alpha and m68k

From: Frédéric Weisbecker
Date: Thu Oct 23 2008 - 13:25:40 EST


2008/10/23 Steven Rostedt <rostedt@xxxxxxxxxxx>:
>
> On Thu, 23 Oct 2008, Fr?d?ric Weisbecker wrote:
>>
>> But to let the core trace.c to be built for other types of tracing,
>> the best thing I see is to put some ifdef CONFIG_TRACE_IRQFLAGS on the
>> tracing_cpumask functions and structure, and actually on the creation
>> of this file.
>
> Is there a reason that you use "raw_local_irq_disable" instead of
> local_irq_disable?


I'm not using anything :)
This is about the tracing_cpumask debugfs file implemented in trace.c
It's tracing_cpumask_write function uses the raw_local functions, I
guess because its locking doesn't need to be traced.
And the problem here is that some archs don't implement raw_local
functions and so trace.c doesn't compile with alpha or m68k.
But actually this file is not needed for them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/