Re: [PATCH 1/2] Add c2 port support.

From: Greg KH
Date: Thu Oct 23 2008 - 11:43:41 EST

On Thu, Oct 23, 2008 at 09:39:57AM +0200, Rodolfo Giometti wrote:
> On Wed, Oct 22, 2008 at 02:03:52PM -0700, Greg KH wrote:
> > > Why is that good? We have hundreds and hundreds of drivers which use a
> > > device node interface and they work OK.
> > >
> > > sysfs was never intended for use as the sole interface between device
> > > drivers and userspace. Using it that way is somewhat unconventional.
> > > At the very least I do think it needs more justification and
> > > explanation than we're being provded here.
> >
> > For firmware download to devices, using sysfs is the "normal" interface
> > these days, that is what the firmware class is for.
> >
> > Which reminds me, Rodolfo, why didn't you just use that interface for
> > your firmware downloading instead of rolling your own here?
> Because I need also to know revision ID, device ID and other minor
> info from the microcontroller.

You can still use sysfs for that, no problems there.

> Also I can reset the microcontroller when I need it without
> downloading any new firmware.

And again, you can still use sysfs for that as well. I was just
referring to the binary sysfs file that you use for the firmware
download, it would make more sense for you to use the standard kernel
firmware download interface instead of rolling your own here.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at