Re: [PATCH] procfs: use WARN() rather than printk+backtrace

From: Arjan van de Ven
Date: Thu Oct 23 2008 - 09:30:29 EST

On Thu, 23 Oct 2008 12:35:47 +0400
Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> On Tue, Oct 21, 2008 at 06:46:12AM -0700, Arjan van de Ven wrote:
> > - printk(KERN_WARNING "proc_dir_entry
> > '%s/%s' already registered\n",
> > + WARN(1, KERN_WARNING "proc_dir_entry
> > '%s/%s' already registered\n",
> Applied to proc.git
> As a side note, seeing WARN twice on this line is depressing, and
> people use WARN(, KERN_ERR);
> I mean, how hard is to get something conceptually simple as warning
> right?

if we were consistent about which level we wanted these things at we
could fold that into the macro. Sadly that's not the case ;(
(and then there's the issue with multilines etc)
Also, WARN() tries to be as printk() compatible as possible, and that
includes the log level....

Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at