Re: Subject: [PATCH 01/16] Squashfs: inode operations

From: Phillip Lougher
Date: Thu Oct 23 2008 - 04:42:24 EST


Geert Uytterhoeven wrote:

Sparse with endian checking (make C=2 CHECKFLAGS="-D__CHECK_ENDIAN__") complains
aibout these:

| fs/squashfs/inode.c:306:25: warning: cast to restricted __le16
| fs/squashfs/inode.c:324:25: warning: cast to restricted __le16

and it seems to be right, as inode.i_mode is not __le16. I think the le16_to_cpu()
should be removed.

Yes, you're right. Fixed thanks.


BTW, there are also a few sparse warnings about different signednesses, so you
probably want to run sparse yourself, too.

I'll do that.

Phillip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/