Re: [PATCH] fix WARN() for PPC

From: Johannes Berg
Date: Thu Oct 23 2008 - 02:27:06 EST

On Wed, 2008-10-22 at 13:23 -0700, Jeremy Fitzhardinge wrote:
> Arjan van de Ven wrote:
> > From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> > Date: Mon, 20 Oct 2008 14:41:03 -0700
> > Subject: [PATCH] fix WARN() for PPC
> >
> > powerpc doesn't use the generic WARN_ON infrastructure.
> Hm, why's that now? The generic infrastructure was taken from powerpc,
> and I thought I'd converted it...

The definition of "generic" changed midway. When you did the "generic"
infrastructure, it was written to use traps for both WARN and BUG. But
then somebody didn't like that and added new "generic" infrastructure
(the one Arjan is talking about) which doesn't use traps for WARN but
rather an unlikely() and an actual function call etc. Then Arjan
improved the latter "generic" infrastructure without regard for the
original one.


Attachment: signature.asc
Description: This is a digitally signed message part