Re: [PATCH 01/42] Staging: add pcc-acpi driver

From: Len Brown
Date: Wed Oct 22 2008 - 22:50:23 EST




On Wed, 22 Oct 2008, Greg KH wrote:

> On Wed, Oct 22, 2008 at 02:37:18PM -0400, Len Brown wrote:
> > NAK.
> > this was already relplaced by the panasonic driver in the acpi tree.
>
> Is this in 2.6.27, or was it a 2.6.28 addition? For some reason, I had
> reports from openSUSE users that 2.6.27 still didn't work properly and
> needed this driver.
>
> How about the new "pcc-acpi-cdrom" driver hack? Hiroshi, is that needed
> still with the 2.6.27 kernel?

drivers/misc/panasonic-laptop.c is staged for 2.6.28:

http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=history;f=drivers/misc/panasonic-laptop.c;h=a2cb598d8ab54a98000d1f31f7c2407924399a5e;hb=test


> > Greg,
> > If it has the word "acpi" in it, please check with me before
> > putting something in the staging tree, for I'd prefer to
> > stage such things in the acpi tree.
>
> Ok, I didn't know you wanted "uncleaned" drivers in your tree, I'll
> remember this for the future :)

AFAICK, the driver that was checked into staging tree
was based on an older version of the driver already staged
in the acpi tree. I think that the staging tree
isn't helping us in this scenario.

thanks,
-Len


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/