Re: [PATCH 03/11] ftrace: return error on failed modified text.

[Steven Rostedt]

On Wed, 22 Oct 2008, Steven Rostedt wrote:
> -			break;
> -		}
> +	ret = ftrace_modify_code(ip, call, nop);
> +	if (ret) {
> +		WARN_ON_ONCE(1);
> +		pr_info("ftrace failed to modify ");
> +		print_ip_sym(ip);
> +		print_ip_ins(" expected: ", call);
> +		print_ip_ins(" replace: ", nop);
> +		printk(KERN_CONT "\n");
> +		break;

This break is an error. I refreshed it in patch 5/11 by mistake.

-- Steve

>  
>  		rec->flags |= FTRACE_FL_FAILED;
>  		return 0;
> 
> -- 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/