Re: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register

[Glauber Costa]

On Wed, Oct 22, 2008 at 12:13 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
>
>> We should touch ESR register if only we have it.
>> The patch fixes the problem mentoined here
>>
>>       http://lkml.org/lkml/2008/10/17/147
>>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
>> CC: Glauber Costa <glommer@xxxxxxxxx>
>
>> -             apic_write(APIC_ESR, 0);
>> -             apic_read(APIC_ESR);
>> +             if (APIC_INTEGRATED(apic_version[phys_apicid])) {
>> +                     apic_write(APIC_ESR, 0);
>> +                     apic_read(APIC_ESR);
>> +             }
>
> i'm wondering - is the server there really that old, that it has no
> integrated lapic? I.e. it's an i486 SMP box or so? Or perhaps some
> other, weird SMP box?

It's a Xeon, so probably just weird.

>
>        Ingo
>



-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/