Re: BUG: sleeping function called from invalid context atkernel/rwsem.c:131 XFS? (was: Re: linux-next: Tree for October 17)
From: Christoph Hellwig
Date: Wed Oct 22 2008 - 06:14:08 EST
On Wed, Oct 22, 2008 at 07:25:50PM +1100, Dave Chinner wrote:
> > Basically the above commit moved xfs_ilock() inside
> > radix_tree_preload()/radix_tree_preload_end(), which means we are
> > taking a rwsem() while we have an elevated preempt count. I'll
> > get a patch out to fix it.
This really needs a warning. Then again I don't really understand this
as the point of radix_tree_preload was that we can do the actual
radix-tree under a lock, or not?
Anyway, the patch looks correct to me, including the slightly unrelated
hunk to fix the missing unlock and preload leak.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/