Re: [PATCH] sound: correct bracketing in spdif test

From: Matthew Ranostay
Date: Tue Oct 21 2008 - 23:38:49 EST


Harvey Harrison wrote:
> Noticed by sparse:
> sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
>
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> ---
> sound/pci/hda/patch_sigmatel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index a2ac720..788fdc6 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
> return err;
> spec->multiout.share_spdif = 1;
> }
> - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
> err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
> if (err < 0)
> return err;

Thanks for finding this.


Acked-by: Matthew Ranostay <mranostay@xxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/