[PATCH 1/1] edac: fix enabling of polling cell module

From: dougthompson
Date: Tue Oct 21 2008 - 21:34:23 EST

From: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

The edac driver on cell turned out to be not enabled because of a missing op_state.
This patch introduces it. Verified to work on top of Bens next branch.

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Jens Osterkamp <jens@xxxxxxxxxxxxxxxxxx>
Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Doug Thompson <dougthompson@xxxxxxxxxxxx>


Ben, can you please confirm this is the patch you wanted to send upstream ?

Index: linux-2.6/drivers/edac/cell_edac.c
--- linux-2.6.orig/drivers/edac/cell_edac.c
+++ linux-2.6/drivers/edac/cell_edac.c
@@ -9,6 +9,7 @@
#undef DEBUG

+#include <linux/edac.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/platform_device.h>
@@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
if (regs == NULL)
return -ENODEV;

+ edac_op_state = EDAC_OPSTATE_POLL;
/* Get channel population */
reg = in_be64(&regs->mic_mnt_cfg);
dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/