Re: [git patches] net driver fixes
From: David Miller
Date: Tue Oct 21 2008 - 19:27:32 EST
From: Jeff Garzik <jeff@xxxxxxxxxx>
Date: Tue, 21 Oct 2008 02:18:51 -0400
> BIG FAT WARNING: This requires upstream's PCIE_LINK_STATE_L0S from
> include/linux/pci-aspm.h in order to build properly. It should build
> if you pull the latest Linus tree into net-2.6, to update net-2.6.
I did the pull from Linus's tree, but the problem is that nothing in
the IGB driver seems to bring that pci-aspm.h include file in.
Thus it doesn't build:
drivers/net/igb/igb_main.c: In function 'igb_probe':
drivers/net/igb/igb_main.c:1018: error: 'PCIE_LINK_STATE_L0S' undeclared (first use in this function)
drivers/net/igb/igb_main.c:1018: error: (Each undeclared identifier is reported only once
drivers/net/igb/igb_main.c:1018: error: for each function it appears in.)
make: *** [drivers/net/igb/igb_main.o] Error 1
make: *** [drivers/net/igb] Error 2
make: *** Waiting for unfinished jobs....
So, I can't see how it builds successfully on any platform :-)
Doing a "git grep pci-aspm.h" shows just a few *.c files under drivers/pci
and nothing else.
Please fix this up.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/