RE: [PATCH 2/2] i7300_idle driver v1.55
From: Pallipadi, Venkatesh
Date: Tue Oct 21 2008 - 19:03:47 EST
>From: Randy Dunlap [mailto:randy.dunlap@xxxxxxxxxx]
>Sent: Tuesday, October 21, 2008 3:15 PM
>To: Pallipadi, Venkatesh
>Cc: Randy Dunlap; Len Brown; Ingo Molnar;
>linux-acpi@xxxxxxxxxxxxxxx; Linux Kernel Mailing List;
>Henroid, Andrew D; Linus Torvalds; Thomas Gleixner; H. Peter
>Anvin; Andi Kleen
>Subject: Re: [PATCH 2/2] i7300_idle driver v1.55
>Pallipadi, Venkatesh wrote:
>> Thanks for the review. Some comments below.
>>> What is debugfs used for? any docs for it?
>> It has some statistics about how many times we went
>> into "memory throttling" state and how long we stayed
>> there since the boot. And one tunable that tunes a
>> parameter changing the policy to start throttling.
>> Will document this with an update patch.
>"Normal" tunables should be in sysfs, not debugfs.
>Or is this just a debugging tunable?
>You surely can't be certain (or require) that debugfs
The lone tunable is debug only. It needs driver to be
compiled with DEBUG flag to be present in debugfs.
We don't want export it in sysfs and some random user
app starts using it and then end up providing backward
compatibility for it in future.
The other two read only variables give some stats about
the driver usage and also kind of debuggish info that
we used during development. Didn't seem worthy enough
to go under sysfs.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/