Re: [PATCH,RFC] ext3: Add support for non-native signed/unsigned htree hash algorithms

From: Daniel Phillips
Date: Tue Oct 21 2008 - 17:51:21 EST

On Monday 20 October 2008 20:43, Theodore Ts'o wrote:
> +static __u32 dx_hack_hash (const char *name, int len, int unsigned_flag)
> ...
> + if (unsigned_flag)
> + c = (int) *ucp++;
> + else
> + c = (int) *scp++;

This being a high performance hash function and all, why not something

+static __u32 uchar_hack_hash (const char *name, int len)

+static __u32 char_hack_hash (const char *name, int len)

+static __u32 dx_hack_hash(const char *name, int len, int unsigned_flag)
+ if (unsigned_flag)
+ return uchar_hack_hash(name, len);
+ return char_hack_hash(name, len);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at