Re: [PATCH v5] HPET: Remove the BKL.

From: David John
Date: Tue Oct 21 2008 - 07:55:12 EST

Ingo Molnar wrote:
> * David John <davidjon@xxxxxxxxxxx> wrote:
>> Remove calls to the BKL as concurrent access is protected
>> by the spinlock hpet_lock.
>> Signed-off-by: David John <davidjon@xxxxxxxxxxx>
>> ---
>> drivers/char/hpet.c | 41 ++++++++++++++++++++++++-----------------
>> 1 files changed, 24 insertions(+), 17 deletions(-)
> this patch still needs to add locking documentation commits to hpet.c,
> which shows that you considered all the locking changes that happen due
> to dropping the BKL. Most of this code runs very rarely so there's
> little chance that races will be caught in practice in any debuggable
> manner.
> Ingo

Ok, will do this. Can you also check the RTC patch I sent that removes
the BKL from the RTC user space driver? The locking is already done,
only the BKL calls needed to be removed.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at