Re: [PATCH] Fix kexec compile error, undeclared 'vmlist'

From: Jens Axboe
Date: Tue Oct 21 2008 - 06:55:13 EST


On Tue, Oct 21 2008, Jens Axboe wrote:
> Hi,
>
> Current -git fails to compile, at least on ppc:
>
> kernel/kexec.c: In function 'crash_save_vmcoreinfo_init':
> kernel/kexec.c:1374: error: 'vmlist' undeclared (first use in this function)
> kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
> kernel/kexec.c:1374: error: for each function it appears in.)
> kernel/kexec.c:1410: error: invalid use of undefined type 'struct vm_struct'
>
> It's missing a vmalloc.h include, introduced by
> acd99dbf54020f5c80b9aa2f2ea86f43cb285b02.
>
> Signed-off-by: Jens Axboe <jens.axboe@xxxxxxxxxx>
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 777ac45..ac0fde7 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -30,6 +30,7 @@
> #include <linux/pm.h>
> #include <linux/cpu.h>
> #include <linux/console.h>
> +#include <linux/vmalloc.h>
>
> #include <asm/page.h>
> #include <asm/uaccess.h>

So this was already fixed and pushed out by Tony, so nevermind the extra
noise. Apparently I had pulled this morning just before, so missed the
last few changes.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/