Re: [PATCH 01/35] x86: clean up speedctep-centrino and reducecpumask_t usage
From: Stephen Rothwell
Date: Mon Oct 20 2008 - 20:09:58 EST
Just a first small thing:
On Mon, 20 Oct 2008 10:03:20 -0700 Mike Travis <travis@xxxxxxx> wrote:
> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
> 3) set_mask is set to either a single cpu or all online cpus in a policy.
> Since it's just used for set_cpus_allowed(), any offline cpus in a policy
> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Mike Travis <travis@xxxxxxx>
The From: line should be the first nonempty line in the mail to get the
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Description: PGP signature