Re: [PATCH 02/10] Make checkpoint/restart functionality modular

[Dave Hansen]

On Sat, 2008-10-18 at 03:11 +0400, Andrey Mirkin wrote:
> +struct cpt_operations
> +{
> +       struct module * owner;
> +       int (*checkpoint)(pid_t pid, int fd, unsigned long flags);
> +       int (*restart)(int ctid, int fd, unsigned long flags);
> +};

I think this is pretty useless obfuscation.  We're not going to have
pluggable checkpoint/restart implementations, are we?  So, why bother
putting it in a module?

I can understand that it's easier to develop your code when it's in a
module and you don't have to reboot the machine to load a new kernel
each time.  But, that's an individual developer thing, and doesn't
belong in an upstream submission.

I know people have given you a hard time for this in the past.  Why is
it still here?

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/