Re: [PATCH] x86: amd_iommu: fix nasty bug that causedILLEGAL_DEVICE_TABLE_ENTRY errors

[Ingo Molnar]

* Joerg Roedel <joro@xxxxxxxxxx> wrote:

> Argh. Very stupid bug. This explains why it worked on my system with 1G
> RAM and failed on some others with more. Thanks for the fix. I also CC
> stable@xxxxxxxxxxx
> 
> On Thu, Oct 16, 2008 at 04:27:36PM +0200, Andreas Herrmann wrote:
> > We are on 64-bit so better use u64 instead of u32 to deal with
> > addresses:
> > 
> > static void __init iommu_set_device_table(struct amd_iommu *iommu)
> > {
> >         u64 entry;
> >   ...
> >         entry = virt_to_phys(amd_iommu_dev_table);
> >   ...
> > 
> > (I am wondering why gcc 4.2.x did not warn about the assignment
> > between u32 and unsigned long.)
> > 
> > Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx
> > Cc: Joerg Roedel <joerg.roedel@xxxxxxx>
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@xxxxxxx>
> 
> Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>

applied to tip/x86/urgent, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/