Re: questions about rd{msr|tsc|pmc} instruction with x86-64

From: Ingo Molnar
Date: Mon Oct 20 2008 - 09:48:16 EST



* Jike Song <albcamus@xxxxxxxxx> wrote:

> H. Peter Anvin wrote:
>> Jike Song wrote:
>> > Thanks, Peter! So I misunderstood the gcc constraint 'A' for x86-64,
>> > but seems the comment "while x86_64 returns at rax" still wrong,
>> > should this be fixed?
>>
>> Yes, feel free to submit a patch.
>>
>> -hpa
> Here you go... CC trivial@xxxxxxxxxx as well.
>
> From 6eed2948d41f959dc113eb3ff30927bcacf34d08 Mon Sep 17 00:00:00 2001
> From: Jike Song <albcamus@xxxxxxxxx>
> Date: Fri, 17 Oct 2008 10:51:13 +0800
> Subject: [PATCH] x86: correct wrong comment
>
> The rdmsr instruction(et al) for i386 and x86-64 are semantically same.
> The only difference is how gcc interpret constraint "A" for these targets.
>
> Signed-off-by: Jike Song <albcamus@xxxxxxxxx>
> ---
> include/asm-x86/msr.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)

applied to tip/x86/cleanups, thanks!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/