[PATCH] x86: call machine_shutdown and stop all CPUs in native_machine_halt

From: Ivan Vecera
Date: Mon Oct 20 2008 - 08:13:32 EST

Function machine_halt (resp. native_machine_halt) is empty for x86
architectures. When command 'halt -f' is invoked, the message
"System halted." is displayed but this is not really true because
all CPUs are still running.
There are also similar inconsistencies for other arches (some uses
power-off for halt or forever-loop with IRQs enabled/disabled).
IMO there should be used the same approach for all architectures
OR what does the message "System halted" really mean?

Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
arch/x86/kernel/reboot.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index f4c93f1..15ad949 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -465,6 +465,14 @@ static void native_machine_restart(char *__unused)

static void native_machine_halt(void)
+ /* stop other cpus and apics */
+ machine_shutdown();
+ /* stop this cpu */
+ local_irq_disable();
+ if (hlt_works(smp_processor_id()))
+ for (;;) halt();
+ for (;;);

static void native_machine_power_off(void)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/